EroticDevelopment wrote: ↑Mon Jan 10, 2022 3:04 amAs always, please let me know here or in a DM if you have any questions, comments, or concerns.
Probably want to remove the reference to the addRepeatTimer functions, since I suggested and you agreed with pulling those out. I've also left comments on some issues that I think are resolved now.
I do plan on removing these as discussed. I don't believe any of that was included in the 0.4.5 release I published, but if I missed something let me know. I have the remaining items you worked on including that and the VLCj update in another branch that I'm testing now. I've run into some weird inconsistencies around the vlclib loading that concerned me a bit so I want to look at that more. Most importantly, I don't believe it's looking for the bundled version anymore and only looking at a system-wide install. I believe I have this fixed, but it seems like a good opportunity to resolve a few other things at the same time.
RemiHiyama wrote: ↑Mon Jan 10, 2022 8:33 am
And while the commit history is there for all to see, I feel like I ought to say for the not-so-much-digging-required record that a good chunk of those things are your work and not mine, I just released a build with them first. (And if I spent enough time I could probably remember which ones are which without having to look them up myself. Probably.)
There's definitely items in there from both of us, but I appreciate the work you did and like to give credit where it's due. You got some big items done while I wasn't available.
And then any exceptions generated by the timer's actions should come immediately following that.
I'm not seeing any issues here either. The code provided looks correct and it works for me. I'll try a few more things and see if maybe it's platform-specific.
RemiHiyama wrote: ↑Tue Jan 11, 2022 5:40 pm
Done some more experimenting with either adding that XInitThreads call myself or using a newer version of vlcj that does that itself. And I keep getting this error:
I've been spending some time looking at this but so far haven't made any major breakthroughs. I kind of know what's causing it, just trying to figure out how to fix it any why. This issue and the video playing in its own window are largely the same issue I believe. Somewhere it's not attaching the video surface correctly.
EroticDevelopment wrote: ↑Mon Jan 17, 2022 5:16 amI do plan on removing these as discussed. I don't believe any of that was included in the 0.4.5 release I published, but if I missed something let me know.
I did some digging and it looks like that never got put back into master on my fork, so there's nothing code-side for you to do; I can just pull that out and submit the backend stuff at a later date, since I think it's still pretty solid and that repeating and/or fractional timers are useful things to have.
EroticDevelopment wrote: ↑Mon Jan 17, 2022 5:21 amI've been spending some time looking at this but so far haven't made any major breakthroughs. I kind of know what's causing it, just trying to figure out how to fix it any why. This issue and the video playing in its own window are largely the same issue I believe. Somewhere it's not attaching the video surface correctly.
Will it actually run for you? I've had crashes on launch with my attempted fixes, but I'm not certain the problem isn't something missing/misconfigured in the VM I'm using for testing the linux build.
Auto: Replaces selected instances of the word "not" with the word "definitely".
And then any exceptions generated by the timer's actions should come immediately following that.
I'm not seeing any issues here either. The code provided looks correct and it works for me. I'll try a few more things and see if maybe it's platform-specific.
Thanks guys. Since I posted that I've moved to a new computer and tried it again today and it works just fine. Go figure. It seems to me I've had that same thing happen before where I tried this or something like it and it didn't work, but after a reboot or something it worked. It was just strange because I tried 3 different guideme versions and had the same issue in all of them.
is it just me, or does GuideMe lowers quality of the images?
GuideMe scales all images to fit the window, whether up or down. In that case, it's enlarged it somewhat. If that bothers you, you might prefer an option to only scale oversize images. I've been thinking about some options for that part of the code anyway, so I can probably look into adding one.
Auto: Replaces selected instances of the word "not" with the word "definitely".
is it just me, or does GuideMe lowers quality of the images?
GuideMe scales all images to fit the window, whether up or down. In that case, it's enlarged it somewhat. If that bothers you, you might prefer an option to only scale oversize images. I've been thinking about some options for that part of the code anyway, so I can probably look into adding one.
Thank you for your answer.
Altought I'm 100% sure it's not just scaling. The quality is reduced and there are also artifacts added.
My guess is that GuideMe is doing some sort of compression of all shown images.
Pseudonym wrote: ↑Mon Jan 24, 2022 5:23 pmAltought I'm 100% sure it's not just scaling. The quality is reduced and there are also artifacts added.
My guess is that GuideMe is doing some sort of compression of all shown images.
I'm pretty sure that's still a result of it going through the scaling function. It shoves every image through it no matter what. And since that function also applies a light blur (which is apparently intended to make scaled down images look better, oops), I think it probably accounts for what you're seeing.
It's possible that the browser control is also introducing artifacts, but I don't think it's likely. But you can see for yourself - if you leave the page open in GuideMe, and go to the /data subdirectory of your GuideMe folder, there should be a file in there with a name beginning with "tmpImage". That's the output of the scaling function. If that shows the same issues, then that confirms their source.
Auto: Replaces selected instances of the word "not" with the word "definitely".
Pseudonym wrote: ↑Mon Jan 24, 2022 5:23 pmAltought I'm 100% sure it's not just scaling. The quality is reduced and there are also artifacts added.
My guess is that GuideMe is doing some sort of compression of all shown images.
I'm pretty sure that's still a result of it going through the scaling function. It shoves every image through it no matter what. And since that function also applies a light blur (which is apparently intended to make scaled down images look better, oops), I think it probably accounts for what you're seeing.
It's possible that the browser control is also introducing artifacts, but I don't think it's likely. But you can see for yourself - if you leave the page open in GuideMe, and go to the /data subdirectory of your GuideMe folder, there should be a file in there with a name beginning with "tmpImage". That's the output of the scaling function. If that shows the same issues, then that confirms their source.
Ah, yes. You are right. Here is the tmp vs original:
Pseudonym wrote: ↑Mon Jan 24, 2022 6:53 pmAgain, if lowering the quality is intended and it has its technical justification, I accept it.
Hmmm, I believe the term I'd use is "overzealous" - it makes sense some of the time, but it's doing it all of the time whether it makes sense or not.
In any event, adding some new options to control this behavior is definitely on my list of things to look into. (Well, technically it was already there, since I don't entirely like how it does things either, but you've brought some things to my attention about it that I hadn't noticed before.)
Auto: Replaces selected instances of the word "not" with the word "definitely".
RemiHiyama wrote: ↑Mon Jan 24, 2022 7:04 pm
Hmmm, I believe the term I'd use is "overzealous" - it makes sense some of the time, but it's doing it all of the time whether it makes sense or not.
In any event, adding some new options to control this behavior is definitely on my list of things to look into. (Well, technically it was already there, since I don't entirely like how it does things either, but you've brought some things to my attention about it that I hadn't noticed before.)
I'm glad to hear that. I always feel like a dick when nitpicking other's work.
Btw I think I found a bug. Disabled buttons can still be triggered by their hotkeys.
Pseudonym wrote: ↑Tue Jan 25, 2022 12:09 am
Btw I think I found a bug. Disabled buttons can still be triggered by their hotkeys.
Yep, the line of code that adds hotkeys doesn't check whether the button is disabled or not at all. Pretty easy fix.
That reminds me. There is another issue I've noticed with hotkeys. If you are on page of a tease that has buttons with hotkeys and open the debug window to jump to another page (like while debugging or testing), if you start typing in the dropdown box to enter a page name, if that page name uses any of the hotkeys, the hotkeys trigger that button, even though technically the Guideme window no longer has focus, the debug window does. You have to jump to some safe page that doesn't have hotkeys, and whose name doesn't use any of the characters used as hotkeys on the active page.
