First of all thanks , for all the changes! :)
I had a bit of a look over the changes in the latest version , and there a few issues that I've noticed.
First , the logic in Next_Session.txt still looks very broken.
For the first bit you currently have :
Code: Select all
(Calc_Commitment_Remaining)
@Variable[#DateDifference(Commitment_Period,Days)]>=[Commitment_Period_Set] @NullResponse @Goto(NoDelay)
@NullResponse @SetVar[Commitment_Remaining]=[#DateDifference(Commitment_Period,Days)]
@NullResponse @ChangeVar[Commitment_Remaining]=[Commitment_Remaining]-[#DateDifference[Commitment_Period]]
This appears to be effectively setting CommitmentRemainng to #DateDifference(Commitment_Period,Days) - #DateDifference[Commitment_Period] , which is probably zero , depending on what the default behaviour is for #DateDifference when you don't specify days/hours/minutes.
I think my suggested fix is probably still the correct thing to do :
Code: Select all
(Calc_Commitment_Remaining)
@Variable[#DateDifference(Commitment_Period,Days)]>=[Commitment_Period_Set] @NullResponse @Goto(NoDelay)
@NullResponse @SetVar[Commitment_Remaining]=[#DateDifference(Commitment_Period,Days)]
@NullResponse @ChangeVar[Commitment_Remaining]=[Commitment_Period_Set]-[Commitment_Remaining]
In the (FinalSession) calculations you have :
Code: Select all
(FinalSession)
As far as I can tell, we have one session remaining before your commitment ends #DT @SetFlag(FinalSession)
@NullResponse @SetVar[Commitment_Remaining]=[#Var[Commitment_Period_Set]]
@NullResponse @SetVar[Temp]=[#DateDifference(Commitment_Period,Hours)]
@NullResponse @ChangeVar[Temp]=[Temp]*[24]
@NullResponse @ChangeVar[Commitment_Remaining]=[Commitment_Remaining]-[#Var[Temp]]
Which means that you are taking a time in hours , and multiplying it by 24 again , and then subtracting it from a value that is in days.
I think the following is the correct thing to do :
Code: Select all
(FinalSession)
As far as I can tell, we have one session remaining before your commitment ends #DT @SetFlag(FinalSession)
@NullResponse @SetVar[Commitment_Remaining]=[#DateDifference(Commitment_Period,Hours)]
@NullResponse @SetVar[Temp]=[Commitment_Period_Set]
@NullResponse @ChangeVar[Temp]=[Temp]*[24]
@NullResponse @ChangeVar[Commitment_Remaining]=[Temp]-[Commitment_Remaining]
Or the following might result in slightly less confusing usage of the variable names:
Code: Select all
(FinalSession)
As far as I can tell, we have one session remaining before your commitment ends #DT @SetFlag(FinalSession)
@NullResponse @SetVar[Temp]=[#DateDifference(Commitment_Period,Hours)]
@NullResponse @SetVar[Commitment_Remaining]=[Commitment_Period_Set]
@NullResponse @ChangeVar[Commitment_Remaining]=[Commitment_Remaining]*[24]
@NullResponse @ChangeVar[Commitment_Remaining]=[Commitment_Remaining]-[Temp]
-------------------------------------------------------------------------------------------------
There was a fix to Edges.txt to stop it from incrementing Edges_Total each loop. I think this same fix also needs to be applied to EdgesHold.txt
-------------------------------------------------------------------------------------------------
Update.txt has a section for (Version123) , but there is nothing that will cause it to be called.